Re: [Qemu-devel] [PATCH v2 09/10] target-arm: optimize neon vld/vst ops

[Aurelien Jarno <aurelien@aurel32.net>]

On Mon, Oct 26, 2009 at 10:11:07AM +0100, Laurent Desnogues wrote:
> On Mon, Oct 26, 2009 at 8:46 AM,  <Juha.Riihimaki@nokia.com> wrote:
> >
> > On Oct 25, 2009, at 16:01, ext Laurent Desnogues wrote:
> >
> >> I don't really like the idea of having tcg_qemu_ld/st not factored
> >> in some place, as it makes memory access tracing extensions
> >> more intrusive.
> >>
> >> This brings us back to the problem having function freeing tmps.
> >> In that case, you could perhaps create a gen_st16_dont_free
> >> function as a temporary workaround?
> >
> > I could, but it is getting ugly =/ How about if I create another patch
> > that moves the temporary variable (de)allocation outside the gen_ldx/
> > gen_stx functions and then refactor this patch on top of that?
> 
> I'd personally like this, but I guess you'd better wait for some inputs
> from other QEMU dev's before doing it.

Looks like the best option to me.

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net