From: Jens Axboe <jens.axboe@oracle.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC]cfq-iosched: improve hw_tag detection
Date: Tue, 27 Oct 2009 08:45:43 +0100 [thread overview]
Message-ID: <20091027074543.GQ10727@kernel.dk> (raw)
In-Reply-To: <20091027005039.GA14819@sli10-desk.sh.intel.com>
On Tue, Oct 27 2009, Shaohua Li wrote:
> On Mon, Oct 26, 2009 at 07:35:55PM +0800, Jens Axboe wrote:
> > On Mon, Oct 26 2009, Shaohua Li wrote:
> > > If active queue hasn't enough requests and idle window opens, cfq will not
> > > dispatch sufficient requests to hardware. In such situation, current code
> > > will zero hw_tag. But this is because cfq doesn't dispatch enough requests
> > > instead of hardware queue doesn't work. Don't zero hw_tag in such case.
> >
> > Thanks, that looks like a good fix. Curious, is this fixing some
> > regression at your end?
> No, just observed such issue when I play with cfq.
OK thanks, just curious. I will apply it for 2.6.33.
--
Jens Axboe
prev parent reply other threads:[~2009-10-27 7:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 9:16 [RFC]cfq-iosched: improve hw_tag detection Shaohua Li
2009-10-26 11:35 ` Jens Axboe
2009-10-27 0:50 ` Shaohua Li
2009-10-27 7:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091027074543.GQ10727@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.