From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N2sAX-0007oR-KP for qemu-devel@nongnu.org; Tue, 27 Oct 2009 15:57:25 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N2sAT-0007mP-7o for qemu-devel@nongnu.org; Tue, 27 Oct 2009 15:57:25 -0400 Received: from [199.232.76.173] (port=45945 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N2sAT-0007mM-0F for qemu-devel@nongnu.org; Tue, 27 Oct 2009 15:57:21 -0400 Received: from mail.gmx.net ([213.165.64.20]:42835) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1N2sAS-0000Hr-As for qemu-devel@nongnu.org; Tue, 27 Oct 2009 15:57:20 -0400 From: "Jan-Simon =?utf-8?q?M=C3=B6ller?=" Subject: Re: [Qemu-devel] [Patch] Make usermode stacksize (-s) configurable at compile-time Date: Tue, 27 Oct 2009 20:56:53 +0100 References: <200910251622.07800.dl9pf@gmx.de> <200910251849.44301.dl9pf@gmx.de> <20091026122516.GA15113@kos.to> In-Reply-To: <20091026122516.GA15113@kos.to> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200910272056.53767.dl9pf@gmx.de> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org > > The attached patch makes this configurable at compile-time. > > fwiw in scratchbox we have a wrapper in between binfmt and qemu (called misc_runner) that sets any > necessary command line parameters for qemu. You might want to consider a similar approach so we > don't need to add a configure option (and thus hardcode the setting) to qemu for every command > line option that might need changing. I got your point. But OTOH I just make the default configurable. IMHO this leads to: * add an (optional) config-file for the usermode to overwrite defaults or * extend and generalize the wrapper and use it in binfmt instead of qemu directly Let me sleep over it a bit - for now: other opinions ? Best, Jan-Simon