From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM AT91 new board EB+CPUx9K2
Date: Tue, 27 Oct 2009 16:27:21 -0500 [thread overview]
Message-ID: <20091027212721.GA26258@loki.buserror.net> (raw)
In-Reply-To: <20091027110234.A0787E916D5@gemini.denx.de>
On Tue, Oct 27, 2009 at 12:02:34PM +0100, Wolfgang Denk wrote:
> > +#define CONFIG_SYS_FLASH_ERASE_TOUT (6*CONFIG_SYS_HZ)
> > +#define CONFIG_SYS_FLASH_WRITE_TOUT (2*CONFIG_SYS_HZ)
>
> This looks wrong to me. A timeout is a time, but CONFIG_SYS_HZ is a
> frequency, i. e. the inverse of a time. These don't mix.
We've been over this:
http://lists.denx.de/pipermail/u-boot/2009-September/059961.html
:-P
C values don't carry units, so you can't assume that multiplying a frequency
by 6 means you want another frequency 6 times as fast.
Whether the timeout is supposed to be expressed in ticks or in some other
unit such as milliseconds is another matter.
-Scott
next prev parent reply other threads:[~2009-10-27 21:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-27 8:38 [U-Boot] [PATCH] ARM AT91 new board EB+CPUx9K2 Jens Scharsig
2009-10-27 11:02 ` Wolfgang Denk
2009-10-27 12:38 ` Jens Scharsig
2009-10-27 18:35 ` Wolfgang Denk
2009-10-28 10:10 ` Jens Scharsig
2009-10-28 14:35 ` Wolfgang Denk
2009-10-29 7:40 ` Jens Scharsig
2009-10-29 10:47 ` Wolfgang Denk
2009-10-29 13:41 ` Jens Scharsig
2009-10-29 13:57 ` Tom
2009-10-29 14:56 ` Wolfgang Denk
2009-10-29 15:21 ` Tom
2009-10-30 8:30 ` Wolfgang Denk
2009-10-30 9:10 ` Jens Scharsig
2009-10-27 21:27 ` Scott Wood [this message]
2009-10-27 11:44 ` Wolfgang Denk
2009-10-27 15:26 ` Jens Scharsig
2009-10-27 19:04 ` Wolfgang Denk
2009-10-28 14:37 ` [U-Boot] [PATCH V2] " Jens Scharsig
2009-10-28 14:42 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091027212721.GA26258@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.