From: Christoph Hellwig <hch@infradead.org>
To: Bill Kendall <wkendall@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] use lpath_to_handle when restoring symlinks
Date: Tue, 27 Oct 2009 23:34:05 -0400 [thread overview]
Message-ID: <20091028033405.GA15502@infradead.org> (raw)
In-Reply-To: <4AE71364.7090102@sgi.com>
On Tue, Oct 27, 2009 at 10:36:04AM -0500, Bill Kendall wrote:
> On 10/25/2009 02:05 AM, Christoph Hellwig wrote:
>> On Thu, Oct 22, 2009 at 11:52:32AM -0500, Bill Kendall wrote:
>>> Update xfsrestore to use the new lpath_to_handle function
>>> when dealing with symlinks.
>>
>> Requiring a simultanously released version of xfsprogs is a very bad
>> idea. The right fix is to add an autoconf check for the new function
>> and use it when available, falling back to the inferior old version
>> if it is not available.
>
> Good thought. However, there's also a run-time dependency since
> xfsrestore uses libhandle.so rather than the .a. I can rework something
> using dlsym - sound okay?
That's why the minor version of a shared library needs to get bumped
when adding a new symbol, see one of my replies to Alex. Of course
symbol versioning would be even better, I'll see if I can port it from
acl/attr which use the same build system as xfsprogs.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2009-10-28 3:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 16:52 [PATCH 2/2] use lpath_to_handle when restoring symlinks Bill Kendall
2009-10-23 18:13 ` Alex Elder
2009-10-25 7:05 ` Christoph Hellwig
2009-10-27 15:36 ` Bill Kendall
2009-10-28 3:34 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091028033405.GA15502@infradead.org \
--to=hch@infradead.org \
--cc=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.