From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 3/4] hwmon-f71882fg: Fix sysfs file removal
Date: Wed, 28 Oct 2009 09:16:07 +0000 [thread overview]
Message-ID: <20091028101607.4e4eb5e8@hyperion.delvare> (raw)
In-Reply-To: <4AE02F6A.1080200@redhat.com>
On Thu, 22 Oct 2009 12:09:46 +0200, Hans de Goede wrote:
> There is a bug in the old sysfs file removal, as it uses fxxxx_in_temp_attr
> to remove the in and temp sysfs attributes, but fxxxx_in_temp_attr has
> temp#_alarm, where as f71858fg_in_temp_attr has temp#_max_alarm, so
> the temp#_max_alarm attributes for the f71858fg never get removed.
>
> This patch fixes this by doing the sysfs removal exactly the same way as
> the creation instead of being (too) clever, this will also avoid similar
> bugs in the future.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Looks good to me.
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2009-10-28 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 10:09 [lm-sensors] [PATCH 3/4] hwmon-f71882fg: Fix sysfs file removal Hans de Goede
2009-10-28 9:16 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091028101607.4e4eb5e8@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.