All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: akpm@linux-foundation.org
Cc: m.s.tsirkin@gmail.com, linux-kernel@vger.kernel.org, stefani@seibold.net
Subject: [PATCH] proc: fix ->stack_start in compat mode
Date: Wed, 28 Oct 2009 14:56:02 +0300	[thread overview]
Message-ID: <20091028115602.GA26295@x200> (raw)

Assign tsk->stack_start even when doing compat execve(2).

As side effect, fix segfault inside boehm-gc library.
http://bugzilla.kernel.org/show_bug.cgi?id=14478

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 Michael, please, confirm.

 Stefani, I get "Stack usage: 0 kB", you may want to look at it.

 fs/compat.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/fs/compat.c
+++ b/fs/compat.c
@@ -1532,6 +1532,8 @@ int compat_do_execve(char * filename,
 	if (retval < 0)
 		goto out;
 
+	current->stack_start = current->mm->start_stack;
+
 	/* execve succeeded */
 	current->fs->in_exec = 0;
 	current->in_execve = 0;

             reply	other threads:[~2009-10-28 11:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-28 11:56 Alexey Dobriyan [this message]
2009-11-01  9:54 ` [PATCH] proc: fix ->stack_start in compat mode Stefani Seibold
2009-11-01 10:21   ` Alexey Dobriyan
2009-11-01 12:43   ` Alexey Dobriyan
2009-11-01 14:42     ` Stefani Seibold
2009-11-01 15:06     ` Stefani Seibold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091028115602.GA26295@x200 \
    --to=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.s.tsirkin@gmail.com \
    --cc=stefani@seibold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.