From: Andrew Morton <akpm@linux-foundation.org>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Linux-MIPS <linux-mips@linux-mips.org>,
linux-serial@vger.kernel.org,
Manuel Lauss <manuel.lauss@gmail.com>
Subject: Re: [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A
Date: Wed, 28 Oct 2009 12:24:30 -0700 [thread overview]
Message-ID: <20091028122430.f7670ae2.akpm@linux-foundation.org> (raw)
In-Reply-To: <1256756954-29211-2-git-send-email-manuel.lauss@gmail.com>
On Wed, 28 Oct 2009 20:09:14 +0100
Manuel Lauss <manuel.lauss@googlemail.com> wrote:
> UART autodetection breaks on the Au1300 but the IP blocks are
> identical, at least in the datasheets.
>
> Pass uart type on to the 8250 driver via platform data, and move
> the MSR quirk to another place sind autoconf() is now no longer
> called on init.
>
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> ---
> Tested on DB1200 and DB1300.
> The mips parts apply on top of Ralf's mips-queue tree.
>
> arch/mips/alchemy/common/platform.c | 4 +++-
> drivers/serial/8250.c | 13 +++++++------
> 2 files changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/arch/mips/alchemy/common/platform.c b/arch/mips/alchemy/common/platform.c
> index 195e5b3..3be14b0 100644
> --- a/arch/mips/alchemy/common/platform.c
> +++ b/arch/mips/alchemy/common/platform.c
> @@ -26,7 +26,9 @@
> .irq = _irq, \
> .regshift = 2, \
> .iotype = UPIO_AU, \
> - .flags = UPF_SKIP_TEST | UPF_IOREMAP \
> + .flags = UPF_SKIP_TEST | UPF_IOREMAP | \
> + UPF_FIXED_TYPE, \
> + .type = PORT_16550A, \
> }
The kernel which you patched differs from current mainline here.
next prev parent reply other threads:[~2009-10-28 19:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 19:09 [PATCH 1/2] serial: 8250: reduce Alchemy serial port space size Manuel Lauss
2009-10-28 19:09 ` [PATCH 2/2] MIPS: Alchemy: UARTs are 16550A Manuel Lauss
2009-10-28 19:24 ` Andrew Morton [this message]
2009-10-28 19:27 ` Manuel Lauss
2009-10-28 19:52 ` Andrew Morton
2009-10-28 20:11 ` Manuel Lauss
2009-10-28 22:34 ` Ralf Baechle
2009-10-28 19:36 ` Sergei Shtylyov
2009-10-28 19:55 ` Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091028122430.f7670ae2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
--cc=manuel.lauss@gmail.com \
--cc=manuel.lauss@googlemail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.