From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: Cleanup redundant tests on unsigned Date: Thu, 29 Oct 2009 01:40:24 -0700 (PDT) Message-ID: <20091029.014024.29284045.davem@davemloft.net> References: <4AE1CA14.10304@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4AE1CA14.10304@gmail.com> Sender: linux-x25-owner@vger.kernel.org List-ID: Content-Type: Text/Plain; charset="us-ascii" To: roel.kluin@gmail.com Cc: netdev@vger.kernel.org, eis@baty.hanse.de, linux-x25@vger.kernel.org, akpm@linux-foundation.org From: Roel Kluin Date: Fri, 23 Oct 2009 17:21:56 +0200 > If there is data, the unsigned skb->len is greater than 0. > > rt.sigdigits is unsigned as well, so the test `>= 0' is > always true, the other part of the test catches wrapped > values. > > Signed-off-by: Roel Kluin Applied.