From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] Set return value to -EINVAL if superblock probe failed
Date: Wed, 28 Oct 2009 23:03:02 -0700 [thread overview]
Message-ID: <20091029060301.GD16472@mail.oracle.com> (raw)
In-Reply-To: <1255339004-20310-1-git-send-email-toth.laszlo.attila@balabit.hu>
On Mon, Oct 12, 2009 at 11:16:44AM +0200, Laszlo Attila Toth wrote:
> In case of non-modular kernels the root filesystem is mounted by trying
> several filesystems. If ocfs2 is tried before the actual filesystem type,
> such as squashfs, the mount is failed because ocfs2_fill_super's return
> value was -EAGAIN and normally it should return with -EINVAL, which means
> the filesystem is non-ocfs2.
ocfs2_sb_probe() shouldn't be returning -EAGAIN in the first
place. I've done a different patch to the same effect, and it is now in
the fixes branch of ocfs2.git.
Joel
--
"What does it say about a society's priorities when the time you
spend in meetings on Monday is greater than the total number of
hours you spent sleeping over the weekend?"
- Nat Friedman
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
prev parent reply other threads:[~2009-10-29 6:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 9:16 [Ocfs2-devel] [PATCH] Set return value to -EINVAL if superblock probe failed Laszlo Attila Toth
2009-10-29 6:03 ` Joel Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091029060301.GD16472@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.