All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Pavel Machek <pavel@ucw.cz>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@redhat.com>,
	Jason Baron <jbaron@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf events: Remove CONFIG_EVENT_PROFILE
Date: Thu, 29 Oct 2009 08:07:31 +0100	[thread overview]
Message-ID: <20091029070731.GD12874@elte.hu> (raw)
In-Reply-To: <4AE93C93.9060607@cn.fujitsu.com>


* Li Zefan <lizf@cn.fujitsu.com> wrote:

> Quote from Ingo:
> 
> | This reminds me - i think we should eliminate CONFIG_EVENT_PROFILE -
> | it's an unnecessary Kconfig complication. If both PERF_EVENTS and
> | EVENT_TRACING is enabled we should expose generic tracepoints.
> |
> | Nor is it limited to event 'profiling', so it has become a misnomer as
> | well.
> 
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> ---
>  include/linux/ftrace_event.h       |    2 +-
>  include/linux/perf_event.h         |    2 +-
>  include/linux/syscalls.h           |    4 ++--
>  include/trace/ftrace.h             |   12 ++++++------
>  include/trace/syscall.h            |    4 ++--
>  init/Kconfig                       |   13 -------------
>  kernel/perf_event.c                |    4 ++--
>  kernel/trace/Makefile              |    4 +++-
>  kernel/trace/trace_events_filter.c |    4 ++--
>  kernel/trace/trace_kprobe.c        |   14 +++++++-------
>  kernel/trace/trace_syscalls.c      |    4 ++--
>  11 files changed, 28 insertions(+), 39 deletions(-)

Thanks!

There's a logistical complication: this rename couples the pending perf 
tree with the pending tracing tree and that makes dependencies a bit 
awkward.

Would you mind to resend this patch in the merge window, to be merged 
soon after both the perf events and the tracing tree went uptream?

The rename/elimination itself looks fine and simple and shouldnt break 
anything, so we dont need to have it in the tracing and perf trees for 
long.

	Ingo

  reply	other threads:[~2009-10-29  7:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-29  6:56 [PATCH] perf events: Remove CONFIG_EVENT_PROFILE Li Zefan
2009-10-29  7:07 ` Ingo Molnar [this message]
2009-10-29  7:10   ` Li Zefan
2009-10-29  7:20     ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2009-12-21  6:27 [PATCH] perf events: remove CONFIG_EVENT_PROFILE Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091029070731.GD12874@elte.hu \
    --to=mingo@elte.hu \
    --cc=fweisbec@gmail.com \
    --cc=jbaron@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mhiramat@redhat.com \
    --cc=pavel@ucw.cz \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.