From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Wang2 Subject: Re: [PATCH] AMD IOMMU: Parse IVRS table early to prevent iommu_enabled from being disabled Date: Thu, 29 Oct 2009 14:51:15 +0100 Message-ID: <200910291451.15908.wei.wang2@amd.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="Boundary-00=_T3Z6KUeJ378xbD2" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org --Boundary-00=_T3Z6KUeJ378xbD2 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Wednesday 28 October 2009 19:03:17 Keir Fraser wrote: > On 28/10/2009 17:46, "Wei Wang2" wrote: > >> Not nice. See if c/s 20381 fixes your problem. It's justa cleanup of > >> some VT-d code which should avoid the problem altogether. > >> > >> -- Keir > > > > Thanks, I have not checked 20381 while creating this patch. > > That's because I created it in response to your patch! :-) > > K. > > > I will test it again and send something new if necessary. Keir, Attached patch removes a BUG_ON condition, to boot amd iommu system correct= ly. Thanks, Wei Signed-off-by: Wei Wang =2D-=20 AMD GmbH, Germany Operating System Research Center Legal Information: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34 85609 Dornach b. M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis M=C3=BCnchen Registergericht M=C3=BCnchen, HRB Nr. 43632 --Boundary-00=_T3Z6KUeJ378xbD2 Content-Type: text/x-diff; charset="utf-8"; name="fix-bug-on.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix-bug-on.patch" diff -r c1f2b68b6dca xen/drivers/passthrough/amd/iommu_init.c --- a/xen/drivers/passthrough/amd/iommu_init.c Wed Oct 28 17:27:47 2009 +0000 +++ b/xen/drivers/passthrough/amd/iommu_init.c Thu Oct 29 12:46:00 2009 +0100 @@ -719,7 +719,7 @@ static int __init amd_iommu_setup_device int sys_mgt, dev_ex, lint1_pass, lint0_pass, nmi_pass, ext_int_pass, init_pass; - BUG_ON( (ivrs_bdf_entries == 0) || (iommu_enabled) ); + BUG_ON( (ivrs_bdf_entries == 0) ); /* allocate 'device table' on a 4K boundary */ device_table.alloc_size = PAGE_SIZE << --Boundary-00=_T3Z6KUeJ378xbD2 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --Boundary-00=_T3Z6KUeJ378xbD2--