From: Lennart Poettering <lennart@poettering.net>
To: linux-hotplug@vger.kernel.org
Subject: Re: [PATCH] extras/keymap: fix build (GEN keys.txt)
Date: Thu, 29 Oct 2009 15:03:26 +0000 [thread overview]
Message-ID: <20091029150326.GA31996@tango.0pointer.de> (raw)
In-Reply-To: <4AE9A648.2090006@tuffmail.co.uk>
On Thu, 29.10.09 14:27, Alan Jenkins (alan-jenkins@tuffmail.co.uk) wrote:
> Commit 7d701b0 "Merge keymap building in the top-level Makefile.am"
> caused a build failure when extras are enabled.
>
> Fix the generation of keys.txt by reverting to the original command.
> -extras/keymap/keys.txt: /usr/include/linux/input.h
> - $(AM_V_GEN)$(AWK) '/^#define.*KEY_[^ ]+[[:space:]]+[0-9]/ { if ($$2 != "KEY_MAX") { print $$2 } }' < $< | sed 's/^KEY_COFFEE$$/KEY_SCREENLOCK/' > $@
> +extras/keymap/keys.txt: /usr/include/linux/input.h Makefile
> + $(AM_V_GEN)$(AWK) '/^#define.*KEY_/ { if ($$2 != "KEY_MAX" &&
> $$2 != "KEY_CNT") { print $$2 } }' < $< > $@
The s/^KEY_COFFEE$$/KEY_SCREENLOCK/ you dropped here actually
matters. It needs to be kept.
Lennart
--
Lennart Poettering Red Hat, Inc.
lennart [at] poettering [dot] net
http://0pointer.net/lennart/ GnuPG 0x1A015CC4
next prev parent reply other threads:[~2009-10-29 15:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 14:27 [PATCH] extras/keymap: fix build (GEN keys.txt) Alan Jenkins
2009-10-29 15:03 ` Lennart Poettering [this message]
2009-10-29 16:01 ` Alan Jenkins
2009-10-29 19:06 ` Martin Pitt
2009-10-29 20:10 ` Alan Jenkins
2009-10-29 20:17 `
2009-10-29 20:40 ` Dan Nicholson
2009-10-29 20:46 `
2009-10-29 20:56 ` Alan Jenkins
2009-10-30 8:40 ` Martin Pitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091029150326.GA31996@tango.0pointer.de \
--to=lennart@poettering.net \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.