From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] Add support for CLKOUT to wm8731 codec driver Date: Fri, 30 Oct 2009 17:00:03 +0000 Message-ID: <20091030170003.GA28420@rakim.wolfsonmicro.main> References: <1256829202-2508-1-git-send-email-bgat@billgatliff.com> <1256829202-2508-2-git-send-email-bgat@billgatliff.com> <20091029160534.GE15559@sirena.org.uk> <4AEB194C.700@billgatliff.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 9A8F824366 for ; Fri, 30 Oct 2009 18:00:04 +0100 (CET) Content-Disposition: inline In-Reply-To: <4AEB194C.700@billgatliff.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Bill Gatliff Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Fri, Oct 30, 2009 at 11:50:20AM -0500, Bill Gatliff wrote: > Mark Brown wrote: > > It'd be better define a new clock for the CLKOUT pin rather than munging > > it in with the master clock. MCLK is always an input on the WM8731, the > > CLKOUT output is a separate pin and so including it in MCLK is likely to > > make things confusing and could well introduce errors. > Could you explain more about what you meant by this? I'm trying to > rework these patches now, and I don't understand how to implement what > you are suggesting. Define two clock IDs and then use a switch statement in the function to determine which to act on, allowing the master clock to be controlled separately to the output clock.