From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N3wfo-0002T1-93 for mharc-grub-devel@gnu.org; Fri, 30 Oct 2009 14:58:08 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N3wfm-0002RR-K1 for grub-devel@gnu.org; Fri, 30 Oct 2009 14:58:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N3wfh-0002N6-Ty for grub-devel@gnu.org; Fri, 30 Oct 2009 14:58:06 -0400 Received: from [199.232.76.173] (port=42748 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3wfh-0002Mt-QF for grub-devel@gnu.org; Fri, 30 Oct 2009 14:58:01 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:46328 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N3wfh-0004tN-7X for grub-devel@gnu.org; Fri, 30 Oct 2009 14:58:01 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1N3wfe-0002e1-Il for grub-devel@gnu.org; Fri, 30 Oct 2009 19:57:58 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1N3wff-0007qw-Ad for grub-devel@gnu.org; Fri, 30 Oct 2009 19:57:59 +0100 Date: Fri, 30 Oct 2009 19:57:59 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20091030185759.GA30150@thorin> References: <57a6d2110910290758i23de79c1y2b87513f674023b@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57a6d2110910290758i23de79c1y2b87513f674023b@mail.gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [patch] grub incorrectly identifies ext3 as fat X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2009 18:58:06 -0000 On Thu, Oct 29, 2009 at 02:58:09PM +0000, Andrew Clausen wrote: > Hi all, > > grub (both the boot loader, and grub-probe) incorrectly identifies my > ext3 partition as containing a fat file system. This means it can't > boot without manual tweaking. The problem is caused by stale fat > signatures... this is probably a common problem, as mke2fs often > doesn't wipe old signatures. > > I wrote a patch. In order for a file system to be considered > detected, dir() must not only succeed, it also must find at least one > file or directory. This is pretty effective at ruling out misdetecting > a filesystem based on a stale signature that wasn't wiped by mkfs. We already had code for this, see: 2009-09-05 Robert Millan * util/grub-probe.c (probe): Comment out buggy codepath, which was unexpectedly enabled by Colin Watson's 2009-09-02 fix. This should be re-enabled after 1.97. > This shouldn't have any collateral damage, because empty file systems > are useless to Grub. Unlike the filesystem driver, grub-probe already knows we want to probe for a file. Then this assumption won't be necessary. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."