From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N4BCq-0002RK-OH for mharc-grub-devel@gnu.org; Sat, 31 Oct 2009 06:29:12 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N4BCp-0002Qp-39 for grub-devel@gnu.org; Sat, 31 Oct 2009 06:29:11 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N4BCk-0002Oy-8a for grub-devel@gnu.org; Sat, 31 Oct 2009 06:29:10 -0400 Received: from [199.232.76.173] (port=58131 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N4BCk-0002Os-0t for grub-devel@gnu.org; Sat, 31 Oct 2009 06:29:06 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:41113 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N4BCj-0005x5-Gj for grub-devel@gnu.org; Sat, 31 Oct 2009 06:29:05 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1N4BCg-0004sV-0k for grub-devel@gnu.org; Sat, 31 Oct 2009 11:29:02 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1N4BCh-0003NS-9S for grub-devel@gnu.org; Sat, 31 Oct 2009 11:29:03 +0100 Date: Sat, 31 Oct 2009 11:29:03 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20091031102903.GD12730@thorin> References: <20091026181010.GA22942@thorin> <4AEB7207.9060009@gmail.com> <20091031100626.GA12730@thorin> <4AEC0EDB.4030901@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AEC0EDB.4030901@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] turn grub-emu into a port X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Oct 2009 10:29:11 -0000 On Sat, Oct 31, 2009 at 11:18:03AM +0100, Vladimir 'phcoder' Serbinenko wrote: > >> - return (tv.tv_sec * GRUB_TICKS_PER_SECOND > >> - + (((tv.tv_sec % GRUB_TICKS_PER_SECOND) * 1000000 + tv.tv_usec) > >> - * GRUB_TICKS_PER_SECOND / 1000000)); > >> + GRUB_COMPILE_TIME_ASSERT (GRUB_TICKS_PER_SECOND == 1000000); > >> + return (tv.tv_sec * 1000000 + tv.tv_usec); > I meant: keep GRUB_TICKS_PER_SECOND=1000000 per default but allow easy > adjustment to any number by coder Ah, you mean instead of assuming (and asserting) that they're 1000000, leave it as a hardcoded "#define GRUB_TICKS_PER_SECOND 1000000" so that this can be changed at source level? Seems fine. If that's what you mean, I'll adjust the patch and add it to experimental. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."