From: Andi Drebes <lists-receive@programmierforen.de>
To: Chris Mason <chris.mason@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Prevent btrfsck to run on mounted filesystems
Date: Sat, 31 Oct 2009 21:46:21 +0100 [thread overview]
Message-ID: <200910312146.21384.lists-receive@programmierforen.de> (raw)
In-Reply-To: <20091030130510.GD2750@think>
> > Just open the nodes with O_EXCL and you'll get all the checking for
> > free. Also make sure that for a pure, read-only checks instead of a
> > repair to allow running on at least a read-only mounted filesystem.
>
> Thanks for working on this patch Andi.
>
> In this case O_EXCL is going to be more accurate just because the
> mounted check doesn't cover every disk in the FS. For now btrfsck
> doesn't really give consistent results even readonly on a mounted
> filesystem. We should prevent it with a message just to prevent
> confusion.
Thanks for the reply. I'll do this as soon as I understand the code that is affected by those changes (I'm still in the learning phase and stepping through the code).
Cheers,
Andi
next prev parent reply other threads:[~2009-10-31 20:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 20:52 [PATCH] Prevent btrfsck to run on mounted filesystems Andi Drebes
2009-10-30 5:02 ` Christoph Hellwig
2009-10-30 13:05 ` Chris Mason
2009-10-31 20:46 ` Andi Drebes [this message]
2009-11-09 14:59 ` Andi Drebes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910312146.21384.lists-receive@programmierforen.de \
--to=lists-receive@programmierforen.de \
--cc=chris.mason@oracle.com \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.