From: Alexey Dobriyan <adobriyan@gmail.com>
To: Stefani Seibold <stefani@seibold.net>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] proc: remove /proc/*/status "Stack usage:"
Date: Sun, 1 Nov 2009 18:53:45 +0300 [thread overview]
Message-ID: <20091101155345.GA3867@x200> (raw)
In-Reply-To: <1257086397.31587.5.camel@wall-e>
On Sun, Nov 01, 2009 at 03:39:57PM +0100, Stefani Seibold wrote:
> Am Sonntag, den 01.11.2009, 16:15 +0300 schrieb Alexey Dobriyan:
> > We have /proc/*/pagemap to determine how much stack was consumed.
> > Leave "threadstack" though.
> >
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> > ---
> >
>
> Stop! /proc/*/pagemap is not a real substitute for the stackm usage
> patch. If you have problems with this patch i will have a look on it.
Why?
You grab thread stack start from /proc/*/stat, then for every page of
stack VMA, you lookup state of page, which is exactly what you're doing
by employing page walker.
next prev parent reply other threads:[~2009-11-01 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-01 13:15 [PATCH] proc: remove /proc/*/status "Stack usage:" Alexey Dobriyan
2009-11-01 14:39 ` Stefani Seibold
2009-11-01 15:53 ` Alexey Dobriyan [this message]
2009-11-01 23:32 ` Stefani Seibold
2009-11-02 5:56 ` Alexey Dobriyan
2009-11-02 10:13 ` Stefani Seibold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091101155345.GA3867@x200 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefani@seibold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.