[PATCH 02/12] ARM: S3C24XX: Introduce S3C2442B CPU

[pavel@ucw.cz (Pavel Machek)]

On Wed 2009-10-28 12:15:43, Ben Dooks wrote:
> From: Harald Welte <laforge@gnumonks.org>
> 
> Add the S3C2442B CPU ID to aid support the Openmoko GTA02 / Freerunner.
> 
> Signed-off-by: Harald Welte <laforge@gnumonks.org>
> Signed-off-by: Andy Green <andy@warmcat.com>
> Signed-off-by: Nelson Castillo <arhuaco@freaks-unidos.net>
> [ben-linux at fluff.org: edit description for clarity and S3C2442B as uppercase]
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
> ---
>  arch/arm/plat-s3c24xx/cpu.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/plat-s3c24xx/cpu.c b/arch/arm/plat-s3c24xx/cpu.c
> index 5447e60..4af9dd9 100644
> --- a/arch/arm/plat-s3c24xx/cpu.c
> +++ b/arch/arm/plat-s3c24xx/cpu.c
> @@ -61,6 +61,7 @@ static const char name_s3c2410[]  = "S3C2410";
>  static const char name_s3c2412[]  = "S3C2412";
>  static const char name_s3c2440[]  = "S3C2440";
>  static const char name_s3c2442[]  = "S3C2442";
> +static const char name_s3c2442b[]  = "S3C2442B";
>  static const char name_s3c2443[]  = "S3C2443";
>  static const char name_s3c2410a[] = "S3C2410A";
>  static const char name_s3c2440a[] = "S3C2440A";
> @@ -112,6 +113,15 @@ static struct cpu_table cpu_ids[] __initdata = {
>  		.name		= name_s3c2442
>  	},
>  	{
> +		.idcode		= 0x32440aab,
> +		.idmask		= 0xffffffff,
> +		.map_io		= s3c244x_map_io,
> +		.init_clocks	= s3c244x_init_clocks,
> +		.init_uarts	= s3c244x_init_uarts,
> +		.init		= s3c2442_init,
> +		.name		= name_s3c2442b

Could we simply put the string here? This is unneccessary
obfuscation... and it is used just once so it does not save
anything...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html