All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colin Watson <cjwatson@ubuntu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH,HURD] Fix root device passing
Date: Mon, 2 Nov 2009 18:50:43 +0000	[thread overview]
Message-ID: <20091102185043.GJ28534@riva.ucam.org> (raw)
In-Reply-To: <20091102173329.GZ5001@const.bordeaux.inria.fr>

On Mon, Nov 02, 2009 at 06:33:29PM +0100, Samuel Thibault wrote:
> The patch below fixes passing root device to GNU Mach.
> With this applied (and some tuning in my hurd /dev/) and my other two
> patches, I could successfully run grub-install and boot!
> 
> Samuel
> 
> 2009-11-02  Samuel Thibault  <samuel.thibault@ens-lyon.org>
> 
> 	* util/grub.d/10_hurd.in: Drop /dev/ prefix from root device path before
> 	giving it to GNU Mach.
> 
> Index: util/grub.d/10_hurd.in
> ===================================================================
> --- util/grub.d/10_hurd.in	(révision 2677)
> +++ util/grub.d/10_hurd.in	(copie de travail)
> @@ -72,8 +72,9 @@
>  menuentry "${OS}" {
>  EOF
>  prepare_grub_to_access_device ${GRUB_DEVICE_BOOT} | sed -e "s/^/\t/"
> +ROOT_DEVICE=`echo ${GRUB_DEVICE} | sed -e 's:^/dev/::'`
>  cat << EOF
> -	multiboot ${kernel} root=device:${GRUB_DEVICE}
> +	multiboot ${kernel} root=device:${ROOT_DEVICE}
>  EOF
>  prepare_grub_to_access_device ${GRUB_DEVICE} | sed -e "s/^/\t/"
>  cat << EOF

'multiboot ${kernel} root=device:${GRUB_DEVICE#/dev/}' would be simpler
and quicker.

-- 
Colin Watson                                       [cjwatson@ubuntu.com]



  reply	other threads:[~2009-11-02 18:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-02 17:33 [PATCH,HURD] Fix root device passing Samuel Thibault
2009-11-02 18:50 ` Colin Watson [this message]
2009-11-02 18:53   ` Samuel Thibault
2009-11-02 19:06     ` Felix Zielcke
2009-11-02 19:12       ` Felix Zielcke
2009-11-02 19:17       ` Samuel Thibault
2009-11-02 19:11     ` Robert Millan
2009-11-02 19:19       ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091102185043.GJ28534@riva.ucam.org \
    --to=cjwatson@ubuntu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.