From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N52JB-0001ac-S9 for mharc-grub-devel@gnu.org; Mon, 02 Nov 2009 14:11:17 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N52JA-0001aP-Gf for grub-devel@gnu.org; Mon, 02 Nov 2009 14:11:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N52J6-0001YD-0p for grub-devel@gnu.org; Mon, 02 Nov 2009 14:11:16 -0500 Received: from [199.232.76.173] (port=51974 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N52J5-0001Y1-SX for grub-devel@gnu.org; Mon, 02 Nov 2009 14:11:11 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:42406 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N52J5-00053s-GL for grub-devel@gnu.org; Mon, 02 Nov 2009 14:11:11 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1N52Iy-0002xO-8n for grub-devel@gnu.org; Mon, 02 Nov 2009 20:11:04 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1N52J1-00031f-1E for grub-devel@gnu.org; Mon, 02 Nov 2009 20:11:07 +0100 Date: Mon, 2 Nov 2009 20:11:07 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20091102191107.GA11570@thorin> References: <20091102173329.GZ5001@const.bordeaux.inria.fr> <20091102185043.GJ28534@riva.ucam.org> <20091102185336.GG4515@const.famille.thibault.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20091102185336.GG4515@const.famille.thibault.fr> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH,HURD] Fix root device passing X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2009 19:11:16 -0000 On Mon, Nov 02, 2009 at 07:53:36PM +0100, Samuel Thibault wrote: > Colin Watson, le Mon 02 Nov 2009 18:50:43 +0000, a écrit : > > 'multiboot ${kernel} root=device:${GRUB_DEVICE#/dev/}' would be simpler > > and quicker. > > And will not work on some systems. I guess at least in the GNU system it's safe to assume that /bin/bash is available? ;-) Note: we follow the convention of using hi case for global variables and low case for private ones, so at the least I'd s/ROOT_DEVICE/root_device/ here. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."