From: Frederic Weisbecker <fweisbec@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: "André Goddard Rosa" <andre.goddard@gmail.com>,
laijs@cn.fujitsu.com, mingo@elte.hu, davem@davemloft.net,
akpm@linux-foundation.org, harvey.harrison@gmail.com,
"linux list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/7] vsprintf: reduce code size by avoiding extra check
Date: Mon, 2 Nov 2009 20:32:50 +0100 [thread overview]
Message-ID: <20091102193248.GC4880@nowhere> (raw)
In-Reply-To: <1257186583.28925.47.camel@Joe-Laptop.home>
On Mon, Nov 02, 2009 at 10:29:43AM -0800, Joe Perches wrote:
> On Mon, 2009-11-02 at 19:19 +0100, Frederic Weisbecker wrote:
> > On Mon, Nov 02, 2009 at 03:26:36PM -0200, André Goddard Rosa wrote:
> > > Subject: [PATCH v2 5/7] vsprintf: reduce code size by avoiding extra check
> > > text data bss dec hex filename
> > > 15735 0 8 15743 3d7f lib/vsprintf.o-before
> > > 15719 0 8 15727 3d6f lib/vsprintf.o-minus-double-check
> > Please add a changelog in your patches, I mean something that
> > explain your practical change.
>
> Read the subject and try not to go overboard.
> I think the changelog André provided is perfect.
It took me some time yesterday to understand how ip6_compressed_string()
does its job, hence it took me some time to ensure this patch is safe,
hence this reaction for something that didn't seem obvious to me at
a first glance.
But you're right actually, the problem was more in my homework than in
the changelog.
next prev parent reply other threads:[~2009-11-02 19:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 17:26 [PATCH v2 5/7] vsprintf: reduce code size by avoiding extra check André Goddard Rosa
2009-11-02 18:19 ` Frederic Weisbecker
2009-11-02 18:29 ` Joe Perches
2009-11-02 19:32 ` Frederic Weisbecker [this message]
2009-11-02 19:36 ` Ingo Molnar
2009-11-02 19:44 ` Frederic Weisbecker
2009-11-02 20:00 ` Ingo Molnar
2009-11-02 19:40 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091102193248.GC4880@nowhere \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andre.goddard@gmail.com \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=joe@perches.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.