From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932285AbZKBUAp (ORCPT ); Mon, 2 Nov 2009 15:00:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932178AbZKBUAo (ORCPT ); Mon, 2 Nov 2009 15:00:44 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:38288 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932107AbZKBUAo (ORCPT ); Mon, 2 Nov 2009 15:00:44 -0500 Date: Mon, 2 Nov 2009 21:00:36 +0100 From: Ingo Molnar To: Frederic Weisbecker Cc: Joe Perches , =?iso-8859-1?Q?Andr=E9?= Goddard Rosa , laijs@cn.fujitsu.com, davem@davemloft.net, akpm@linux-foundation.org, harvey.harrison@gmail.com, linux list Subject: Re: [PATCH v2 5/7] vsprintf: reduce code size by avoiding extra check Message-ID: <20091102200036.GA4682@elte.hu> References: <20091102181944.GA4880@nowhere> <1257186583.28925.47.camel@Joe-Laptop.home> <20091102193248.GC4880@nowhere> <20091102193623.GB9948@elte.hu> <20091102194412.GD4880@nowhere> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20091102194412.GD4880@nowhere> User-Agent: Mutt/1.5.19 (2009-01-05) X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Frederic Weisbecker wrote: > On Mon, Nov 02, 2009 at 08:36:23PM +0100, Ingo Molnar wrote: > > > > * Frederic Weisbecker wrote: > > > > > On Mon, Nov 02, 2009 at 10:29:43AM -0800, Joe Perches wrote: > > > > On Mon, 2009-11-02 at 19:19 +0100, Frederic Weisbecker wrote: > > > > > On Mon, Nov 02, 2009 at 03:26:36PM -0200, André Goddard Rosa wrote: > > > > > > Subject: [PATCH v2 5/7] vsprintf: reduce code size by avoiding extra check > > > > > > text data bss dec hex filename > > > > > > 15735 0 8 15743 3d7f lib/vsprintf.o-before > > > > > > 15719 0 8 15727 3d6f lib/vsprintf.o-minus-double-check > > > > > Please add a changelog in your patches, I mean something that > > > > > explain your practical change. > > > > > > > > Read the subject and try not to go overboard. > > > > I think the changelog André provided is perfect. > > > > > > > > > It took me some time yesterday to understand how > > > ip6_compressed_string() does its job, hence it took me some time to > > > ensure this patch is safe, hence this reaction for something that > > > didn't seem obvious to me at a first glance. > > > > > > But you're right actually, the problem was more in my homework than in > > > the changelog. > > > > Since you wrote the last iteration of that bit and you didnt find it > > > André wrote this patch, not me :) i know - i mean you touched the vsprintf code last materially. But i see that there's been this commit since then: 8a27f7c: lib/vsprintf.c: Add "%pI6c" - print pointer as compressed ipv6 address which introduced ip6_compressed_string(). Ingo