From: Jarek Poplawski <jarkao2@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next-2.6] ifb: RCU locking avoids touching dev refcount
Date: Mon, 2 Nov 2009 22:40:55 +0100 [thread overview]
Message-ID: <20091102214055.GA2358@ami.dom.local> (raw)
In-Reply-To: <4AEF504C.7000401@gmail.com>
On Mon, Nov 02, 2009 at 10:34:04PM +0100, Eric Dumazet wrote:
> Jarek Poplawski a écrit :
...
> > So, how is skb->dev protected here, above and below? It seems these
> > rcu read blocks need extending, don't they?
> >
>
> Well, this might be true, but we run under tasklet (softirq) with preemption disabled.
>
> We might move rcu_read_unlock() some lines down to not rely on this.
I think it's needed now at least for readability.
Jarek P.
prev parent reply other threads:[~2009-11-02 21:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 5:45 [PATCH net-next-2.6] ifb: RCU locking avoids touching dev refcount Eric Dumazet
2009-11-02 7:57 ` David Miller
2009-11-02 21:14 ` Jarek Poplawski
2009-11-02 21:34 ` Eric Dumazet
2009-11-02 21:40 ` Jarek Poplawski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091102214055.GA2358@ami.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.