From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org Subject: + arch-arm-plat-s3c24xx-move-dereference-after-null-test.patch added to -mm tree Date: Mon, 02 Nov 2009 22:24:43 -0800 Message-ID: <200911030624.nA36OhEV030643@imap1.linux-foundation.org> Reply-To: linux-kernel@vger.kernel.org Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:36576 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751426AbZKCGZF (ORCPT ); Tue, 3 Nov 2009 01:25:05 -0500 Sender: mm-commits-owner@vger.kernel.org List-Id: mm-commits@vger.kernel.org To: mm-commits@vger.kernel.org Cc: julia@diku.dk, ben-linux@fluff.org, linux@arm.linux.org.uk The patch titled arch/arm/plat-s3c24xx: Move dereference after NULL test has been added to the -mm tree. Its filename is arch-arm-plat-s3c24xx-move-dereference-after-null-test.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: arch/arm/plat-s3c24xx: Move dereference after NULL test From: Julia Lawall If the NULL test on buf is needed, then the dereference should be after the NULL test. A simplified version of the semantic match that detects this problem is as follows (http://coccinelle.lip6.fr/): // @match exists@ expression x, E; identifier fld; @@ * x->fld ... when != \(x = E\|&x\) * x == NULL // Signed-off-by: Julia Lawall Cc: Ben Dooks Cc: Russell King Signed-off-by: Andrew Morton --- arch/arm/plat-s3c24xx/dma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff -puN arch/arm/plat-s3c24xx/dma.c~arch-arm-plat-s3c24xx-move-dereference-after-null-test arch/arm/plat-s3c24xx/dma.c --- a/arch/arm/plat-s3c24xx/dma.c~arch-arm-plat-s3c24xx-move-dereference-after-null-test +++ a/arch/arm/plat-s3c24xx/dma.c @@ -208,14 +208,14 @@ s3c2410_dma_loadbuffer(struct s3c2410_dm { unsigned long reload; - pr_debug("s3c2410_chan_loadbuffer: loading buff %p (0x%08lx,0x%06x)\n", - buf, (unsigned long)buf->data, buf->size); - if (buf == NULL) { dmawarn("buffer is NULL\n"); return -EINVAL; } + pr_debug("s3c2410_chan_loadbuffer: loading buff %p (0x%08lx,0x%06x)\n", + buf, (unsigned long)buf->data, buf->size); + /* check the state of the channel before we do anything */ if (chan->load_state == S3C2410_DMALOAD_1LOADED) { _ Patches currently in -mm which might be from julia@diku.dk are origin.patch linux-next.patch drivers-scsi-libsas-use-sam_good.patch drivers-block-dac960c-use-dac960_v2_controller.patch drivers-char-ipmi-use-kcs_idle_state.patch drivers-message-move-dereference-after-null-test.patch drivers-acpi-move-dereference-after-null-test.patch drivers-media-video-move-dereference-after-null-test.patch drivers-mmc-move-dereference-after-null-test.patch drivers-cpuidle-move-dereference-after-null-test.patch drivers-video-move-dereference-after-null-test.patch drivers-ata-libata-move-dereference-after-null-test.patch drivers-scsi-remove-unnecessary-null-test.patch arch-arm-plat-omap-drop-an-unnecessary-null-test.patch arch-arm-plat-s3c24xx-move-dereference-after-null-test.patch