From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodolfo Giometti Date: Tue, 03 Nov 2009 08:17:14 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon w83627hf: add mfd support. Message-Id: <20091103081714.GK19538@enneenne.com> List-Id: References: <1252585810-5336-2-git-send-email-giometti@linux.it> In-Reply-To: <1252585810-5336-2-git-send-email-giometti@linux.it> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lm-sensors@vger.kernel.org On Mon, Nov 02, 2009 at 02:23:28PM +0100, Jean Delvare wrote: > Hi Rodolfo, > > On Thu, 1 Oct 2009 15:53:50 +0200, Samuel Ortiz wrote: > > > On Thu, 24 Sep 2009 14:01:11 +0200, Rodolfo Giometti wrote: > > > > The file has been splitted up into two parts: > > > > > > > > * drivers/mfd/w83627hf-core.c - detects the chip and define proper > > > > platform devices into mfd support > > > > > > > > * drivers/hwmon/w83627hf.c - implements the driver for hwmon > > > > functionality only > > > > > > > > Signed-off-by: Rodolfo Giometti > > > > --- > > > > drivers/hwmon/Kconfig | 1 + > > > > drivers/hwmon/w83627hf.c | 376 ++++++++++++------------------------------ > > > > drivers/mfd/Kconfig | 15 ++ > > > > drivers/mfd/Makefile | 1 + > > > > drivers/mfd/w83627hf-core.c | 186 +++++++++++++++++++++ > > > > include/linux/mfd/w83627hf.h | 118 +++++++++++++ > > > > 6 files changed, 428 insertions(+), 269 deletions(-) > > > > create mode 100644 drivers/mfd/w83627hf-core.c > > > > create mode 100644 include/linux/mfd/w83627hf.h > > > (...) > > > The rest starts looking good. > > > > Same here. As far as the MFD part is concerned, it's fine with me except for > > this one missing WARN_ON(). > > I'll wait until we get Jean's ack for the hwmon part, and push it through my > > for-next branch. > > Any news from this patch? It would be great to have it ready for merge > in kernel 2.6.33. I see, but unfortunately I'm stuck on other issues with higher priority... I'm trying to fix up the patch ASAP even if I don't guarantee to be in time for kernel 2.6.33. I'm sorry for that. Ciao, Rodolfo -- GNU/Linux Solutions e-mail: giometti@enneenne.com Linux Device Driver giometti@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors