From: Ralf Baechle <ralf@linux-mips.org>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: David Daney <ddaney@caviumnetworks.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Make collection of FPU emulator statistics optional.
Date: Tue, 3 Nov 2009 10:37:43 +0100 [thread overview]
Message-ID: <20091103093743.GA23235@linux-mips.org> (raw)
In-Reply-To: <20091103093024.GA6425@alpha.franken.de>
On Tue, Nov 03, 2009 at 10:30:24AM +0100, Thomas Bogendoerfer wrote:
> On Mon, Nov 02, 2009 at 04:12:35PM -0800, David Daney wrote:
> > On SMP systems, the collection of statistics can cause cache line
> > bouncing in the lines associated with the counters. Make the
> > statistics configurable so this can be avoided. Also we need to make
> > the counters atomic_t so that they can be reliably modified on SMP
> > systems.
>
> how about making it a per_cpu thing and avoid the atomic instructions ?
Working on that. The tricky part is that statistics may end up somewhat
inaccurate when a reader iterates over the per-CPU array of stats to add
them all up. I've not found a solution for that yet but then again it
should not be something which actually would cause pain.
Ralf
next prev parent reply other threads:[~2009-11-03 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 0:12 [PATCH] MIPS: Make collection of FPU emulator statistics optional David Daney
[not found] ` <20091103093024.GA6425@alpha.franken.de>
2009-11-03 9:37 ` Ralf Baechle [this message]
2009-11-03 10:21 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091103093743.GA23235@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.