All of lore.kernel.org
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Junio C Hamano <gitster@pobox.com>, David Brown <davidb@codeaurora.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] commit: More generous accepting of RFC-2822 footer lines.
Date: Tue, 3 Nov 2009 17:59:51 +0100	[thread overview]
Message-ID: <20091103165951.GA2241@neumann> (raw)
In-Reply-To: <7vd447o0jp.fsf@alter.siamese.dyndns.org>

Hi,

> > From: David Brown <davidb@quicinc.com>
> >
> > 'git commit -s' will insert a blank line before the Signed-off-by
> > line at the end of the message, unless this last line is a
> > Signed-off-by line itself.  Common use has other trailing lines
> > at the ends of commit text, in the style of RFC2822 headers.
> >
> > Be more generous in considering lines to be part of this footer.
> > If the last paragraph of the commit message reasonably resembles
> > RFC-2822 formatted lines, don't insert that blank line.

I think this patch was a bit too generous.  If I make a one-line
commit message with git commit -s -m which has a colon in it, e.g.
'subsystem: what I did', then this patch removes the empty line
between the subject and the SOB line.


Best,
Gábor

  parent reply	other threads:[~2009-11-03 17:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-27 23:45 [PATCH] commit: More generous accepting of RFC-2822 footer lines David Brown
2009-10-28  0:05 ` Shawn O. Pearce
2009-10-28  7:14   ` Junio C Hamano
2009-10-28 14:23     ` David Brown
2009-10-28 17:13 ` David Brown
2009-10-28 18:06   ` Junio C Hamano
2009-10-28 18:17     ` David Brown
2009-11-03 16:59     ` SZEDER Gábor [this message]
2009-11-04  3:09       ` [PATCH] commit: fix too generous RFC-2822 footer handling SZEDER Gábor
2009-11-04  6:11         ` Junio C Hamano
2009-11-04 15:11           ` SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091103165951.GA2241@neumann \
    --to=szeder@ira.uka.de \
    --cc=davidb@codeaurora.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.