From: Bob Copeland <me@bobcopeland.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: CSights <csights@fastmail.fm>, linux-wireless@vger.kernel.org
Subject: Re: ath5k and ".local" dropout
Date: Tue, 3 Nov 2009 14:25:48 -0500 [thread overview]
Message-ID: <20091103192548.GB10464@hash.localnet> (raw)
In-Reply-To: <20091103190149.GE4839@tuxdriver.com>
On Tue, Nov 03, 2009 at 02:01:49PM -0500, John W. Linville wrote:
> > We zero out the mcast filter for some reason, I'm not sure why. Maybe
> > missing tildes in front of the zeroes or something.
>
> Any feedback on that patch? :-)
Positive, so far. Saving CSights the trouble of requoting :) I'll push it
unless C pops up with "any other problem"...
> > diff --git a/drivers/net/wireless/ath/ath5k/base.c
> > b/drivers/net/wireless/ath/ath5k/base.c index 1287ded..1e6e0b6 100644
> > --- a/drivers/net/wireless/ath/ath5k/base.c
> > +++ b/drivers/net/wireless/ath/ath5k/base.c
> > @@ -1125,7 +1125,6 @@ ath5k_mode_setup(struct ath5k_softc *sc)
> > /* configure operational mode */
> > ath5k_hw_set_opmode(ah);
> >
> > - ath5k_hw_set_mcast_filter(ah, 0, 0);
> > ATH5K_DBG(sc, ATH5K_DEBUG_MODE, "RX filter 0x%x\n", rfilt);
> > }
>
> YES!
> At least I am able to ping for longer than 2 minutes. :) I'll keep
> running the modified code and see if any other problem crops up.
--
Bob Copeland %% www.bobcopeland.com
prev parent reply other threads:[~2009-11-03 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 0:07 ath5k and ".local" dropout CSights
2009-11-03 18:00 ` John W. Linville
2009-11-03 18:54 ` Bob Copeland
2009-11-03 19:01 ` John W. Linville
2009-11-03 19:25 ` Bob Copeland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091103192548.GB10464@hash.localnet \
--to=me@bobcopeland.com \
--cc=csights@fastmail.fm \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.