From: Ralf Baechle <ralf@linux-mips.org>
To: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [-queue] arch/mips/kernel/linux32.c:304: error: implicit declaration of function 'lock_kernel'
Date: Wed, 4 Nov 2009 07:12:05 +0100 [thread overview]
Message-ID: <20091104061205.GB610@linux-mips.org> (raw)
In-Reply-To: <1257314349.3778.62.camel@falcon.domain.org>
On Wed, Nov 04, 2009 at 01:59:09PM +0800, Wu Zhangjin wrote:
> When I compile the queue branch of your -queue git repo, meet this
> error:
>
> arch/mips/kernel/linux32.c: In function 'SYSC_32_sysctl':
> arch/mips/kernel/linux32.c:304: error: implicit declaration of function
> 'lock_kernel'
> arch/mips/kernel/linux32.c:307: error: implicit declaration of function
> 'unlock_kernel'
>
> and found you have removed this <linux/smp_lock.h> header file in
> linux32.c in this commit:
>
> commit 0adcf22332d4da33629568fd14e00069cbf002e6
> Author: Ralf Baechle <ralf@linux-mips.org>
> Date: Tue Nov 3 23:06:18 2009 +0100
>
> MIPS: Don't include <linux/smp_lock.h> unnecessarily.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
>
> :100644 100644 938b1d0... 3676660... M
> arch/mips/basler/excite/excite_iodev.c
> :100644 100644 b77fefa... 07cc39e... M arch/mips/kernel/linux32.c
> :100644 100644 364f066... dcaed1b... M arch/mips/kernel/rtlx.c
> :100644 100644 6047752... 2bd2151... M arch/mips/kernel/vpe.c
> :100644 100644 15ea778... ed2453e... M
> arch/mips/sibyte/common/sb_tbprof.c
There is another patch from Thomas Gleixner pending which will push down
the lock_kernel calls deeper into the sysctl calls. I also had that
patch applied so missed that build failure.
> So, revert it for linux32.c?
Yes, that's what I'll do for now.
Thanks!
Ralf
prev parent reply other threads:[~2009-11-04 6:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 5:59 [-queue] arch/mips/kernel/linux32.c:304: error: implicit declaration of function 'lock_kernel' Wu Zhangjin
2009-11-04 6:12 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091104061205.GB610@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.