All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: yodor1@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: kernel BUG at mm/highmem.c:259
Date: Wed, 4 Nov 2009 08:36:14 +0100	[thread overview]
Message-ID: <20091104073613.GR8742@kernel.dk> (raw)
In-Reply-To: <E1N5Zwf-0005r9-Fn@pomaz-ex.szeredi.hu>

On Wed, Nov 04 2009, Miklos Szeredi wrote:
> On Tue, 3 Nov 2009, Jens Axboe wrote:
> > Looks like another victim of the confusing kmap() vs kmap_atomic() API
> > differences.
> > 
> > diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> > index a3492f7..8a219bd 100644
> > --- a/fs/fuse/file.c
> > +++ b/fs/fuse/file.c
> > @@ -1599,7 +1599,7 @@ static int fuse_ioctl_copy_user(struct page **pages, struct iovec *iov,
> >  			kaddr += copy;
> >  		}
> >  
> > -		kunmap(map);
> > +		kunmap(page);
> >  	}
> >  
> >  	return 0;
> 
> Todor, thanks for the bug report!  Jens, can I add your Signed-off-by?

Yes certainly, go ahead. I should have signed it off when posting.

-- 
Jens Axboe


      reply	other threads:[~2009-11-04  7:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-02 20:30 kernel BUG at mm/highmem.c:259 Todor Gyumyushev
2009-11-03 10:40 ` Jens Axboe
2009-11-04  7:06   ` Miklos Szeredi
2009-11-04  7:36     ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091104073613.GR8742@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=yodor1@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.