All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Ortiz <sameo@linux.intel.com>
To: Ben Dooks <ben@simtec.co.uk>
Cc: linux-kernel@vger.kernel.org, dbrownell@users.sourceforge.net,
	Simtec Liunx Team <linux@simtec.co.uk>
Subject: Re: tps65010: Allow the board to choose any GPIO base.
Date: Wed, 4 Nov 2009 12:43:54 +0100	[thread overview]
Message-ID: <20091104114353.GA3607@sortiz.org> (raw)
In-Reply-To: <20091102165220.310450538@fluff.org.uk>

Hi Ben,

On Mon, Nov 02, 2009 at 04:52:20PM +0000, Ben Dooks wrote:
> If the board does not care where the TPS turns up, then specifiying the
> value -1 to get gpiolib to dynamically allocate the base for the chip
> is valid.
> 
> Change the test to look for != 0, so that any boards specifying zero
> will not end up with gpio that they didn't want.
> 
> Signed-off-by: Ben Dooks <ben@simtec.co.uk>
> Signed-off-by: Simtec Liunx Team <linux@simtec.co.uk>
Applied, thanks a lot.


> ---
>  drivers/mfd/tps65010.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: b/drivers/mfd/tps65010.c
> ===================================================================
> --- a/drivers/mfd/tps65010.c	2009-10-21 19:09:28.000000000 +0100
> +++ b/drivers/mfd/tps65010.c	2009-10-21 19:09:39.000000000 +0100
> @@ -637,7 +637,7 @@ static int tps65010_probe(struct i2c_cli
>  				tps, DEBUG_FOPS);
>  
>  	/* optionally register GPIOs */
> -	if (board && board->base > 0) {
> +	if (board && board->base != 0) {
>  		tps->outmask = board->outmask;
>  
>  		tps->chip.label = client->name;
> 
> -- 
> Ben (ben@fluff.org, http://www.fluff.org/)
> 
>   'a smiley only costs 4 bytes'

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

      reply	other threads:[~2009-11-04 11:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-02 16:52 tps65010: Allow the board to choose any GPIO base Ben Dooks
2009-11-04 11:43 ` Samuel Ortiz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091104114353.GA3607@sortiz.org \
    --to=sameo@linux.intel.com \
    --cc=ben@simtec.co.uk \
    --cc=dbrownell@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@simtec.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.