From: Jarek Poplawski <jarkao2@gmail.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Jamal Hadi Salim <hadi@cyberus.ca>, devik@cdi.cz, netdev@vger.kernel.org
Subject: Re: [PATCH] sch_htb.c consume the classes's tokens bellow the HTB_CAN_SEND level
Date: Wed, 4 Nov 2009 11:49:22 +0000 [thread overview]
Message-ID: <20091104114922.GA8176@ff.dom.local> (raw)
In-Reply-To: <412e6f7f0911040321o22c536fdid078f6d2225a90a0@mail.gmail.com>
On Wed, Nov 04, 2009 at 07:21:48PM +0800, Changli Gao wrote:
...
> > cl->mbuffer is only to limit some extreme effects, so more of an
> > exception, not a main tool of rate control. (It really should be
> > useless most of the time if classes don't stop sending and aren't
> > deprived of their full rate for really long time.)
> >
>
> I don't think so. Although a class's tokens may be negative, but its
> ctokens may be positive. Charging its tokens is to prevent its cmode
> from being changed to HTB_CAN_SEND from HTB_CANT_SEND directly.
I think, you should really better show some tests proving your patch
is needed and doesn't affect a case I described, instead of trying to
discuss the meaninig of all HTB variables here.
Regards,
Jarek P.
next prev parent reply other threads:[~2009-11-04 11:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 2:41 [PATCH] sch_htb.c consume the classes's tokens bellow the HTB_CAN_SEND level Changli Gao
2009-11-03 8:00 ` Jarek Poplawski
2009-11-03 9:47 ` Changli Gao
2009-11-03 10:05 ` Jarek Poplawski
2009-11-03 13:18 ` Changli Gao
2009-11-03 23:00 ` Jarek Poplawski
2009-11-04 1:53 ` Changli Gao
2009-11-04 8:28 ` Jarek Poplawski
2009-11-04 9:16 ` Changli Gao
2009-11-04 10:42 ` Jarek Poplawski
2009-11-04 10:58 ` Martin Devera
2009-11-04 11:30 ` Changli Gao
2009-11-04 11:51 ` Martin Devera
2009-11-04 11:58 ` Martin Devera
2009-11-04 12:08 ` Changli Gao
2009-11-04 12:15 ` Martin Devera
2009-11-05 5:44 ` Changli Gao
2009-11-04 11:21 ` Changli Gao
2009-11-04 11:49 ` Jarek Poplawski [this message]
2009-11-04 12:01 ` Changli Gao
2009-11-04 12:11 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091104114922.GA8176@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=devik@cdi.cz \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.