From: Christian Lamparter <chunkeey@googlemail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>,
linux-wireless@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [RFC] usb: Check results of dma_map_single
Date: Wed, 4 Nov 2009 20:49:02 +0100 [thread overview]
Message-ID: <200911042049.02761.chunkeey@googlemail.com> (raw)
In-Reply-To: <4af115c3.JUDAYfcydqPYCYyH%Larry.Finger@lwfinger.net>
On Wednesday 04 November 2009 06:48:51 Larry Finger wrote:
> At http://marc.info/?l=linux-wireless&m=125695331205062&w=2, a problem
> with DMA buffer processing was corrected for the libertas driver. Because
> routine usb_fill_bulk_urb() does not check that DMA is possible when
^^^
hmm, usb_fill_bulk_urb? No, that should be usb_submit_urb :)
http://osdir.com/ml/linux-wireless/2009-10/msg01182.html
> dma_map_single() is called, this condition was not detected until the buffer
> was unmapped. By this time memory corruption had occurred.
>
> The situation is fixed by testing the returned DMA address. If not a legal
> address, a WARN_ON(1) is executed to provide traceback and the error is
> returned.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
next prev parent reply other threads:[~2009-11-04 19:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 5:48 [RFC] usb: Check results of dma_map_single Larry Finger
2009-11-04 12:50 ` Paulius Zaleckas
2009-11-04 14:06 ` Larry Finger
2009-11-04 14:51 ` Michael Buesch
2009-11-04 15:16 ` Larry Finger
2009-11-04 19:49 ` Christian Lamparter [this message]
2009-11-05 2:41 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911042049.02761.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@suse.de \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.