All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Kirby <sim@hostway.ca>
To: Simon Horman <horms@verge.net.au>
Cc: lvs-devel@vger.kernel.org
Subject: [PATCH] Fix ip_vs_lblcr_full_check to remove unused entries instead of used entries.
Date: Thu, 5 Nov 2009 00:37:16 -0800	[thread overview]
Message-ID: <20091105083716.GE5244@hostway.ca> (raw)
In-Reply-To: <20091105013511.GA12797@verge.net.au>

Tested with real packets -- seems to work.

Signed-off-by: Simon Kirby <sim@hostway.ca>

---
 net/netfilter/ipvs/ip_vs_lblcr.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/netfilter/ipvs/ip_vs_lblcr.c b/net/netfilter/ipvs/ip_vs_lblcr.c
index 715b57f..937743f 100644
--- a/net/netfilter/ipvs/ip_vs_lblcr.c
+++ b/net/netfilter/ipvs/ip_vs_lblcr.c
@@ -432,7 +432,7 @@ static inline void ip_vs_lblcr_full_check(struct ip_vs_service *svc)
 
 		write_lock(&svc->sched_lock);
 		list_for_each_entry_safe(en, nxt, &tbl->bucket[j], list) {
-			if (time_after(en->lastuse+sysctl_ip_vs_lblcr_expiration,
+			if (time_before(en->lastuse+sysctl_ip_vs_lblcr_expiration,
 				       now))
 				continue;
 
-- 
1.6.5.2

  reply	other threads:[~2009-11-05  8:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-05  0:38 ip_vs_lblcr logic error causing table flushing Simon Kirby
2009-11-05  1:35 ` Simon Horman
2009-11-05  8:37   ` Simon Kirby [this message]
2009-11-05  9:43     ` [PATCH] Fix ip_vs_lblcr_full_check to remove unused entries instead of used entries Simon Kirby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091105083716.GE5244@hostway.ca \
    --to=sim@hostway.ca \
    --cc=horms@verge.net.au \
    --cc=lvs-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.