From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N635y-00083I-Be
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 09:13:50 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N635r-00080t-AK
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 09:13:47 -0500
Received: from [199.232.76.173] (port=54159 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N635p-00080g-VL
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 09:13:42 -0500
Received: from mx20.gnu.org ([199.232.41.8]:45428)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <dan@codesourcery.com>)
	id 1N635p-0002Hq-QH
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 09:13:41 -0500
Received: from mail.codesourcery.com ([38.113.113.100])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <dan@codesourcery.com>) id 1N635n-0004VW-R2
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 09:13:40 -0500
Date: Thu, 5 Nov 2009 09:13:35 -0500
From: Daniel Jacobowitz <dan@codesourcery.com>
Message-ID: <20091105141335.GY3983@caradoc.them.org>
References: <cover.1257428255.git.quintela@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1257428255.git.quintela@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 0/2] Build fixes
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org

On Thu, Nov 05, 2009 at 02:42:51PM +0100, Juan Quintela wrote:
> Hi
> 
> This series fixes the parallel build of qemu.  I tried to get the best of
> Daniel and Stefan ideas with mine.
> Once there fixed an obvious fix.
> 
> Daniel, can you check that parallel build also works for you?  It works for me (TM).

No, it doesn't work.

  GEN  config-all-devices.mak
  GEN   config-host.h
  GEN   config-all-devices.h
  CC    qemu-tool.o
  CC    cutils.o
In file included from /scratch/dan/qemu/src/qemu-trunk/qemu-tool.c:14:
/scratch/dan/qemu/src/qemu-trunk/qemu-common.h:32:25: error:
config-host.h: No such file or directory
make: *** [qemu-tool.o] Error 1

You have to define GENERATED_HEADERS before you use it in
dependencies, I believe.  But you've got it way down below the
rules.mak invocation.

Also, your changes to $(QEMU_PROG) and recurse-all are not necessary;
they're the same sort of ordering assumption that caused the original
bug.  You only need to depend on generated files if you're going to
use them in this rule's commands; for headers, that means invoke a .c
to .o compilation.  The dependencies should be on exactly the rules
that need them.

I didn't bother with Makefile.target since the headers are generated
in the top level and that make will remain recursive.

-- 
Daniel Jacobowitz
CodeSourcery