From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N63v5-00051R-R5
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 10:06:39 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N63v1-0004ws-S3
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 10:06:39 -0500
Received: from [199.232.76.173] (port=53357 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N63v1-0004wW-Mo
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 10:06:35 -0500
Received: from moutng.kundenserver.de ([212.227.17.9]:65031)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <arnd@arndb.de>) id 1N63v0-0003nK-Td
	for qemu-devel@nongnu.org; Thu, 05 Nov 2009 10:06:35 -0500
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 5 Nov 2009 16:06:27 +0100
References: <1257294485-27015-1-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1257294485-27015-1-git-send-email-aliguori@us.ibm.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <200911051606.27974.arnd@arndb.de>
Subject: [Qemu-devel] Re: [PATCH 0/4] net-bridge: rootless bridge support
	for qemu
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Mark McLoughlin <markmc@redhat.com>, Arnd Bergmann <arndbergmann@googlemail.com>, Dustin Kirkland <kirkland@canonical.com>, Michael Tsirkin <mst@redhat.com>, Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org

On Wednesday 04 November 2009, Anthony Liguori wrote:
> And assuming a bridge is defined named qemubr0 and the administrator has setup
> permissions accordingly, it will Just Work.  My hope is that distributions will
> do this work as part of the qemu packaging process such that for most users,
> the out-of-the-box experience will also Just Work.
> 
> More details are included in individual patches.  I broke up the helper into
> a series of patches to improve reviewabilty.

Looks all very nice. I'm not completely sure if qemu is the right place to
put the helper though. I can see that it helps you to have it there, but
basically anyone using tun/tap could use the same functionality, so packaging
it together with tunctl would be nice, either in the same binary or as
two binaries in the same package.

Then again, tunctl is (on some distros as least) part of the uml-utilities
package for similar reasons, which feels equally wrong now.

	Arnd <><