All of lore.kernel.org
 help / color / mirror / Atom feed
From: Max Kellermann <max@duempel.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: linux-kernel@vger.kernel.org, mk@cm4all.com
Subject: Re: [PATCH] pipe: don't block after data has been written
Date: Thu, 5 Nov 2009 17:36:03 +0100	[thread overview]
Message-ID: <20091105163603.GA4089@squirrel.roonstrasse.net> (raw)
In-Reply-To: <4AF2FD04.4030306@gmail.com>

On 2009/11/05 17:27, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Your patch breaks many programs, that dont use poll()/select()
> 
> char result[1000000];
> main()
> {
> 	computethings();
> 	write(1, buffer, 1000000);
> }

Your code does not check the return value of write().  This is a bug.

So how exactly does my patch break this program?

Let's read some more of the manual you cited: "If a write() requests
that more bytes be written than there is room for (for example, the
process' file size limit or the physical end of a medium), only as
many bytes as there is room for shall be written."

  reply	other threads:[~2009-11-05 16:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-05 15:31 [PATCH] pipe: don't block after data has been written Max Kellermann
2009-11-05 16:20 ` Américo Wang
2009-11-05 16:25   ` Max Kellermann
2009-11-05 16:27 ` Eric Dumazet
2009-11-05 16:36   ` Max Kellermann [this message]
2009-11-05 16:37     ` Eric Dumazet
2009-11-05 17:13       ` Zan Lynx
2009-11-05 18:32         ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091105163603.GA4089@squirrel.roonstrasse.net \
    --to=max@duempel.org \
    --cc=eric.dumazet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mk@cm4all.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.