Re: [PATCH] pci/pcie: Avoid unnecessary PCIe link retrains

[Matthew Wilcox <matthew@wil.cx>]

On Thu, Nov 05, 2009 at 12:59:25PM -0600, Bjorn Helgaas wrote:
> Here's another possibility, the idea being to collect all the PCIe
> stuff in one place.  This would require a lot of changes in the PCIe
> driver code, but most of them would be trivial.

I don't like the idea of kmallocing a 6- or 10-byte data structure
... better to keep it in the pci_dev.  Maybe embedding a pcie_dev inside
the pci_dev would be a good idea, but unless there're more things to
move to it, this seems like a net loss to me.

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."