Re: [PATCH] MokoTouch

[Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>]

Dnia czwartek, 5 listopada 2009 o 23:16:19 David Lanzendörfer napisał(a):

> +++ b/recipes/mokotouch/mokotouch-apps-helloworld_2.bb
> @@ -0,0 +1,24 @@
> +require mokotouch.inc
> +
> +DEPENDS = "mokotouch-coreservices-mokotouch"
> +
> +do_configure(){
> +cd ${S}/MokoTouch/Apps/HelloWorld
> +rm UIKit.framework
> +ln -s "${S}/MokoTouch/Frameworks/UIKit/" UIKit.framework
> +${OE_QMAKE_QMAKE} HelloWorld.pro
> +}
> +
> +do_compile(){
> +cd ${S}/MokoTouch/Apps/HelloWorld
> +oe_runmake
> +}
> +
> +do_install(){
> +install -d "${D}/${libdir}"
> +install "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0"
>  "${D}/${libdir}/libHelloWorld.so.1.0.0" +install
>  "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0"
>  "${D}/${libdir}/libHelloWorld.so.1.0" +install
>  "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0"
>  "${D}/${libdir}/libHelloWorld.so.1" +install
>  "${S}/MokoTouch/Apps/HelloWorld/BUILD/App/libHelloWorld.so.1.0.0"
>  "${D}/${libdir}/libHelloWorld.so" +}

My version of that recipe:

=============================
require mokotouch.inc

MTCOMPONENT = "HelloWorld"
=============================

Rest of code should be in mokotouch.inc as you only change component name in 
all recipes. Each and each repeats same errors:

- no setting of ${S} but use of "cd somewhere to make it build"
- big duplication of code
- no use of qmake* bbclasses which remove need of do_configure/do_compile in
  your recipes
- again waste of space by strange installation of libraries (fix loader to use
  *.so maybe and skip all *.so.1.0.0 stuff?)

Still nack from me.

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz