From: Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
To: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: Liran Liss <liranl-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>,
Or Gerlitz <or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Yevgeny Petrilin
<yevgenyp-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Tziporet Koren <tziporet-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
Subject: Re: [PATCH 19/25] mlx4: Randomizing mac addresses for slaves
Date: Fri, 6 Nov 2009 18:07:46 +1100 [thread overview]
Message-ID: <20091106070736.GA12697@verge.net.au> (raw)
In-Reply-To: <adaeiocyykl.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
On Thu, Nov 05, 2009 at 10:08:58PM -0800, Roland Dreier wrote:
>
> > > igb uses the full output of random_ether_addr(). I'd be fine with
> > > that. However setting the OUI means you only get 24 bits of randomness
> > > which makes a collision a lot more likely.
> >
> > IIRC that was precisely why the OUI isn't used for the igb driver.
> >
> > Perhaps some infrastructure (by which I mean a random_mac() function)
> > is warranted so at least this discussion can be concentrated around that
> > rather than repeating it for each driver that needs random mac addresses.
>
> What would be the difference between random_mac() and the existing
> random_ether_addr() function?
Sorry, I was mistaken. igb is using random_ether_addr(),
which is what I had in mind.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-11-06 7:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 15:31 [PATCH 19/25] mlx4: Randomizing mac addresses for slaves Yevgeny Petrilin
[not found] ` <4AF19E69.8070605-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
2009-11-04 20:04 ` Roland Dreier
2009-11-04 21:33 ` Or Gerlitz
[not found] ` <15ddcffd0911041333l165ee274mfae3508a3db755e7-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-11-05 13:38 ` Liran Liss
2009-11-05 13:38 ` Liran Liss
[not found] ` <2ED289D4E09FBD4D92D911E869B97FDD0166CA59-ia22CT07NJfiMCgWhms8HQC/G2K4zDHf@public.gmane.org>
2009-11-05 15:58 ` Roland Dreier
2009-11-05 15:58 ` Roland Dreier
2009-11-06 4:06 ` Simon Horman
[not found] ` <20091106040624.GA6629-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2009-11-06 6:08 ` Roland Dreier
[not found] ` <adaeiocyykl.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2009-11-06 7:07 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091106070736.GA12697@verge.net.au \
--to=horms-/r6kz+ddxgppr4jqbcensq@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=liranl-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org \
--cc=tziporet-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
--cc=yevgenyp-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.