From mboxrd@z Thu Jan  1 00:00:00 1970
Date: Fri, 6 Nov 2009 10:20:18 +0100
From: Richard Cochran <richardcochran@domain.hid>
Message-ID: <20091106092018.GB5306@domain.hid>
References: <1257259464.2210.32.camel@domain.hid>
	<20091104055659.GA5280@domain.hid>
	<1257328464.2210.66.camel@domain.hid>
	<20091104111536.GA14614@domain.hid>
	<1257334005.2210.86.camel@domain.hid>
	<20091104140832.GA32220@domain.hid>
	<20091104181907.GA24561@domain.hid>
	<1257372981.2210.160.camel@domain.hid>
	<20091106081033.GA5306@domain.hid>
	<1257496018.2210.243.camel@domain.hid>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1257496018.2210.243.camel@domain.hid>
Subject: Re: [Xenomai-core] [Xenomai core] Freeze on MPC8572 and P2020 with
	SMP
List-Id: Xenomai life and development <xenomai.xenomai.org>
List-Unsubscribe: <https://mail.gna.org/listinfo/xenomai-core>,
	<mailto:xenomai-core-request@domain.hid>
List-Archive: </public/xenomai-core>
List-Post: <mailto:xenomai@xenomai.org>
List-Help: <mailto:xenomai-core-request@domain.hid>
List-Subscribe: <https://mail.gna.org/listinfo/xenomai-core>,
	<mailto:xenomai-core-request@domain.hid>
To: Philippe Gerum <rpm@xenomai.org>
Cc: xenomai@xenomai.org

On Fri, Nov 06, 2009 at 09:26:58AM +0100, Philippe Gerum wrote:
> Ouch. I just can't believe this went unnoticed for that long... Well, no
> wonder why then, the critical IPI never gets registered, so never
> detected by the pipeline core in __ipipe_grab_irq. Thanks for the heads
> up.
> 
> This may make things work a little better:

Yes, works fine now. Thanks for your help.

Richard

> diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
> index 8968b24..a4fe229 100644
> --- a/arch/powerpc/kernel/smp.c
> +++ b/arch/powerpc/kernel/smp.c
> @@ -164,16 +164,16 @@ int smp_request_message_ipi(int virq, int msg)
>  	if (msg < 0 || msg > PPC_MSG_DEBUGGER_BREAK) {
>  		return -EINVAL;
>  	}
> -#if !defined(CONFIG_DEBUGGER) && !defined(CONFIG_KEXEC)
> -	if (msg == PPC_MSG_DEBUGGER_BREAK) {
> -		return 1;
> -	}
> -#endif
>  #ifdef CONFIG_IPIPE
>  	if (msg == PPC_MSG_DEBUGGER_BREAK)
>  		/* Piggyback the debugger IPI for the I-pipe. */
>  		__ipipe_register_ipi(virq);
>  #endif
> +#if !defined(CONFIG_DEBUGGER) && !defined(CONFIG_KEXEC)
> +	if (msg == PPC_MSG_DEBUGGER_BREAK) {
> +		return 1;
> +	}
> +#endif
>  
>  	err = request_irq(virq, smp_ipi_action[msg], IRQF_DISABLED|IRQF_PERCPU,
>  			  smp_ipi_name[msg], 0);
> 
> -- 
> Philippe.
> 
>