From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jane Wang <jwang@ti.com>
Cc: alsa-devel@alsa-project.org, peter.ujfalusi@nokia.com
Subject: Re: [PATCH]ASoc:ZOOM2:Add support for DSP rendering.
Date: Fri, 6 Nov 2009 14:03:07 +0000 [thread overview]
Message-ID: <20091106140306.GD10371@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1257459691-12411-1-git-send-email-jwang@ti.com>
On Thu, Nov 05, 2009 at 04:21:31PM -0600, Jane Wang wrote:
> New mixer controls added to send dapm stream events to power up/down TWL4030
> DAPM widgets along playback and capture paths. In case of DSP rendering,
> use the corresponding mixer control to power up widgets before stream starts
> and power down the widges after stream stops.
What does the hardware look like and what is the problem you're trying
to solve here? Sending stream events into the core is a definite
layering violation and is likely to fail with some use case transitions
but without knowing what the patch is trying to achieve it's hard to
offer much advice.
> +static const char *path_control[] = {"Off", "On"};
> +static const struct soc_enum zoom2_enum[] = {
> + SOC_ENUM_SINGLE_EXT(ARRAY_SIZE(path_control), path_control),
> +};
Why is this an enumerated control and not a switch?
next parent reply other threads:[~2009-11-06 14:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1257459691-12411-1-git-send-email-jwang@ti.com>
2009-11-06 14:03 ` Mark Brown [this message]
2009-11-09 17:22 ` [PATCH]ASoc:ZOOM2:Add support for DSP rendering Wang, Jane
2009-11-10 13:03 ` Mark Brown
2009-11-11 8:38 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091106140306.GD10371@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jwang@ti.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.