From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 01/11] sysctl: Separate the binary sysctl logic into it's own file. Date: Fri, 6 Nov 2009 14:11:19 +0100 Message-ID: <200911061411.19580.arnd@arndb.de> References: <200911061310.02785.arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from moutng.kundenserver.de ([212.227.126.186]:52991 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752287AbZKFNL2 (ORCPT ); Fri, 6 Nov 2009 08:11:28 -0500 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: "Eric W. Biederman" Cc: Christian Borntraeger , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org On Friday 06 November 2009, Eric W. Biederman wrote: > The primary proc path already doesn't need the lock_kernel(). My next > patch winds up killing the entire binary path and rebuilding on top of > /proc/sys. Which removes that lock_kernel(). > > Which I think elegantly solves all of the sysctl BKL lock issues. Yes, that sounds like an excellent plan, but I'm not completely sure if the lack of the BKL in the procfs case is intentional. As a particular case that I stumbled over, 'core_pattern' is read with the BKL held to protect against sysctl changing it, but it is changed with proc_dostring without the BKL. Most uses of intvec or string seem to be racy and probably need a proper serialization method anyway. Arnd <><