From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
Graeme Gregory <gg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC - Add support for upto 16 channels on OMAP MCBSP
Date: Fri, 6 Nov 2009 15:00:14 +0000 [thread overview]
Message-ID: <20091106150013.GA27699@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1257517520.3624.564.camel@odin>
On Fri, Nov 06, 2009 at 02:25:20PM +0000, Liam Girdwood wrote:
> static inline int snd_soc_get_framesize(int clock, struct snd_pcm_hw_params *params);
That's roughly what I'm thinking of too - it doesn't even need to take
the clock in since the frame size is unrelated to the clock in (and the
calculation is also useful for devices which have FLLs they can use to
vary the system clock to meet their bit clock requirements). We'd also
want a versions that takes the TDM parameters in for use when
configuring that.
I'll pull the relevant code out of some of my drivers sometime over the
next few days.
Most of the devices I've seen that couldn't use this stuff at all
actually need to maintain some sample rate ratio for their master clock
and don't need to worry about BCLK since the fs restriction usually
takes care of it.
> static inline int snd_soc_get_divider(int clock, struct snd_pcm_hw_params *params);
This one I'm less sure about, partly due to naming but also because it
tends to be where you end up with restrictions that'd need handling in
drivers - I'm not sure that you'd save anything that wasn't already
saved with the above two functions.
next prev parent reply other threads:[~2009-11-06 15:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-04 17:53 [PATCH] ASoC - Add support for upto 16 channels on OMAP MCBSP Liam Girdwood
2009-11-04 18:28 ` Mark Brown
2009-11-04 18:55 ` Graeme Gregory
2009-11-04 19:46 ` Liam Girdwood
2009-11-05 7:51 ` Jarkko Nikula
2009-11-05 14:55 ` Liam Girdwood
2009-11-05 19:28 ` Jarkko Nikula
2009-11-05 20:08 ` Liam Girdwood
2009-11-06 13:20 ` Mark Brown
2009-11-06 14:25 ` Liam Girdwood
2009-11-06 15:00 ` Mark Brown [this message]
2009-11-05 8:14 ` Peter Ujfalusi
2009-11-05 8:26 ` Peter Ujfalusi
2009-11-05 10:05 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091106150013.GA27699@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=gg@slimlogic.co.uk \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.