Re: [LTP] LTP 20091031 Makefiles totally broken?!?

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 1748 bytes --]

On Friday 06 November 2009 18:02:31 Matt Helsley wrote:
> On Fri, Nov 06, 2009 at 03:09:02PM -0400, Mike Frysinger wrote:
> > On Friday 06 November 2009 13:04:51 Garrett Cooper wrote:
> > > As I just wrote in the INSTALL file after the release (I apologize for
> > > not catching this beforehand, but all of the systems I use -- Fedora,
> > > Gentoo, RHEL 4 update 6, Ubuntu -- have make 3.81):
> >
> > hrm, it sucks to not support make 3.80.  while make 3.81 has been out for
> > three years now, make 3.80 support would increase the coverage to 8
> > years. but if you've looked at the situation and found 3.80 support to be
> > non trivial, i wont whine too loud.
> >
> > > In order to compile and use pan, you must have bison/yacc, flex, and
> > > make 3.81+ installed.
> >
> > if we're forcing make-3.81+, then make it explicit:
> > ifneq ($(findstring x3.7,x$(MAKE_VERSION)),)
> 
> This snippet might work better than findstring. If the make version is
> greater than or equal to 3.81 then NEED_NEWER_MAKE is n:
> 
> NEED_NEWER_MAKE := n
> MAX_VERSION := $(shell echo 3.81 $(MAKE_VERSION) | xargs -r -n 1 | sort -V
>  -r | head -n 1)

this involves executing a shell and a lot of external utilities.  my version 
requires an internal make string search.  anything that involves $(shell) here 
is going to be worse.

> > also, i thought we were going to rename the top level Makefile to
> > GNUmakefile and add a dummy Makefile that just spat out "sorry, ltp
> > requires GNU make".
> 
> Bleh. Can't we just check the output of $(MAKE) --version rather than
> assume other makes use "Makefile"?

the assumption is that only GNU make parses "GNUmakefile".  i think that's a 
pretty safe assumption.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 354 bytes --]

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list