From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: dm snapshot: allow live exception store handover between tables Date: Fri, 6 Nov 2009 14:54:30 -0500 Message-ID: <20091106195429.GE13427@redhat.com> References: <1257532814-17100-1-git-send-email-snitzer@redhat.com> <20091106184642.GC13427@redhat.com> <20091106192620.GD13427@redhat.com> <20091106194136.GT13375@agk-dp.fab.redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20091106194136.GT13375@agk-dp.fab.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Alasdair G Kergon Cc: dm-devel@redhat.com, Mikulas Patocka List-Id: dm-devel.ids On Fri, Nov 06 2009 at 2:41pm -0500, Alasdair G Kergon wrote: > On Fri, Nov 06, 2009 at 02:26:21PM -0500, Mike Snitzer wrote: > > OK, actually in practice 'lvchange --refresh' is: > > old->suspend > > new->ctr > > Those two need to be swapped. > (I think it's a pre-existing userspace bug that's simple to fix.) Why do they _need_ to be swapped? > > old->resume > > - device-mapper: snapshots: Unable to handover exceptions to another snapshot on resume. > > new->resume > > - snapshot_resume: handing over exceptions > > Handover to new device and make it live first, then remove old device. > It doesn't make sense to me to remove the old device before the new one has > successfully taken over from it. OK, I'm not sure how to make that happen within lvm2's deptree. I'll have a look. So you're saying refresh should result in: new->ctr old->suspend new->resume old->resume Mike