From: Oleg Nesterov <oleg@redhat.com>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH] ptrace: copy_thread() should clear TIF_SINGLESTEP and X86_EFLAGS_TF
Date: Fri, 6 Nov 2009 22:50:04 +0100 [thread overview]
Message-ID: <20091106215004.GA2232@redhat.com> (raw)
In-Reply-To: <20091106212554.BD731CF@magilla.sf.frob.com>
On 11/06, Roland McGrath wrote:
>
> There is also the TIF_FORCED_TF logic to check.
I thought this flag has no effect without TIF_SINGLESTEP, and it is
always updated by enable_single_step().
> Probably it should just
> call user_disable_single_step() instead. Perhaps copy_process() should
> just call that and then no per-arch changes would be required.
OK, thanks, will resend tomorrow.
user_disable_single_step() is very much arch-dependent, I am worried
if it is safe to call it from copy_process(), when the new task_struct,
thread_info, etc are not properly initialized yet...
Oleg.
next prev parent reply other threads:[~2009-11-06 21:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 21:16 [PATCH] ptrace: copy_thread() should clear TIF_SINGLESTEP and X86_EFLAGS_TF Oleg Nesterov
2009-11-06 21:25 ` Roland McGrath
2009-11-06 21:50 ` Oleg Nesterov [this message]
2009-11-06 22:10 ` Roland McGrath
2009-11-07 21:55 ` [PATCH] ptrace: copy_process() should disable stepping Oleg Nesterov
2009-11-09 4:15 ` Roland McGrath
2009-11-09 16:24 ` Oleg Nesterov
2009-11-09 23:53 ` [PATCH v2] " Oleg Nesterov
2009-11-10 20:39 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091106215004.GA2232@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.