All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: linux-kernel@vger.kernel.org, otus-devel@venema.h4ckr.net,
	Luis.Rodriguez@Atheros.com
Subject: Re: [PATCH] staging/otus: trivial, fix sparse warnig.
Date: Fri, 6 Nov 2009 14:47:28 -0800	[thread overview]
Message-ID: <20091106224728.GA32205@kroah.com> (raw)
In-Reply-To: <1256861066-21954-1-git-send-email-tfransosi@gmail.com>

On Thu, Oct 29, 2009 at 08:04:26PM -0400, Thiago Farina wrote:
> *apdbg.c: use NULL pointer instead of 0 integer.
> 
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> ---
>  drivers/staging/otus/apdbg.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/otus/apdbg.c b/drivers/staging/otus/apdbg.c
> index d3e2f62..70a40b8 100644
> --- a/drivers/staging/otus/apdbg.c
> +++ b/drivers/staging/otus/apdbg.c
> @@ -109,7 +109,7 @@ int set_ioctl(int sock, struct ifreq *req)
>  
>  int read_reg(int sock, struct ifreq *req)
>  {
> -    struct zdap_ioctl *zdreq = 0;
> +    struct zdap_ioctl *zdreq = NULL;

The tabs somehow got converted to spaces in your patches, so they can't
be applied :(

care to rediff both of them?

thanks,

greg k-h

  reply	other threads:[~2009-11-06 23:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-30  0:04 [PATCH] staging/otus: trivial, fix sparse warnig Thiago Farina
2009-11-06 22:47 ` Greg KH [this message]
2009-11-06 23:47   ` Thiago Farina
2009-11-07  0:07     ` Greg KH
2009-11-07  1:23       ` Thiago Farina
2009-11-07  1:45         ` [PATCH v2] " Thiago Farina
2009-11-19 19:34           ` Greg KH
2009-11-20 19:18             ` Thiago Farina
2009-11-20 19:22               ` Greg KH
2009-11-20 20:09                 ` Thiago Farina
2009-11-20 20:15                   ` Greg KH
2009-11-20 21:22                     ` Thiago Farina
2009-11-20 21:28                       ` Greg KH
2009-11-07  0:20     ` [PATCH] " Thiago Farina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091106224728.GA32205@kroah.com \
    --to=greg@kroah.com \
    --cc=Luis.Rodriguez@Atheros.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=otus-devel@venema.h4ckr.net \
    --cc=tfransosi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.