From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [patch] added brightness feature to lcd class. Date: Sat, 7 Nov 2009 17:48:30 +0100 Message-ID: <20091107164830.GA1586@ucw.cz> References: <90b950fc0911020050q3bc3fae8j954ec6ed73d79b5@mail.gmail.com> <20091105192725.GE1392@ucw.cz> <90b950fc0911070443s57d2ec5ehcb5c9cf9edcf8d8c@mail.gmail.com> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: <90b950fc0911070443s57d2ec5ehcb5c9cf9edcf8d8c@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: InKi Dae Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Kyungmin Park On Sat 2009-11-07 21:43:50, InKi Dae wrote: > Thank you for your comments. > > using backlight is good way in case of TFT-LCD Panel. > because TFT-LCD Panel needs backlight device to light up. > > but AMOLED LCD Panel doesn't need backlight device because lighting up itself. I know. So what? User wants to set brightness. Why should userspace know/care if it is TFT or AMOLED? I have this script: #!/bin/bash echo $1 > /sys/class/backlight/*/brightness why should I have to rewrite it just because you decided amoled is special? Kernel is expected to provide hw abstraction... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html